| Revision as of 11:50, 18 April 2023 editHurricane Noah (talk | contribs)29,325 edits →Edit request 18 April 2023← Previous edit |
Latest revision as of 21:22, 30 July 2024 edit undoCewbot (talk | contribs)Bots7,433,547 editsm Maintain {{WPBS}}: 1 WikiProject template. Create {{WPBS}}.Tag: Talk banner shell conversion |
| (32 intermediate revisions by 7 users not shown) |
| Line 1: |
Line 1: |
|
|
{{Talk page header}} |
|
{{Permanently protected}} |
|
|
|
{{WikiProject banner shell| |
|
{{WikiProject Weather | tropical-cyclones-project=yes}} |
|
{{WikiProject Weather | tropical-cyclones-project=yes}} |
|
|
}} |
|
|
|
|
|
{{Permanently protected}} |
|
== Template-protected edit request on 11 April 2022 == |
|
|
|
{{User:MiszaBot/config |
|
|
|
|
|
| algo = old(60d) |
|
{{edit template-protected|Module:Storm categories/categories|answered=yes}} |
|
|
|
| archive = Module talk:Storm categories/Archive %(counter)d |
|
Given the concerns regarding the changed colors and their relation to the ongoing ArbCom case against WPTC regarding stealth canvassing (which the process was heavily tainted by) – brought up ], ] and ] (the last one brought up by me specifically to get more input from members) – I propose that until the ArbCom case is finalized on May 4 (under a month from now) the legacy colors be temporarily restored until a decision on what to do regarding the RfC’s outcomes is made. The reasoning behind this is mostly to fix the discrepancy between the infoboxes/timelines and the track maps themselves, given that the project was in the middle of re-discussing a new scheme after the previous consensus and had not updated the maps. Even now, currently active systems are still using the old color scale for the track maps so I think it is better that at least for the next month we follow that so as to not give confusion to new readers. This is a genuine concern and not a case of ] as I am considering the ramifications the currently convoluted situation has right now on our new readers. ''''']''''' (<sup>]</sup>/<sub>]</sub>) 15:29, 11 April 2022 (UTC) |
|
|
|
| archiveheader = {{Archive|Module talk:Storm categories}} |
|
:Please keep this to a single discussion where you ]. ~ ] (]) 17:38, 11 April 2022 (UTC) |
|
|
|
| counter = 1 |
|
::{{Not done}}. We are not doing this. The proper process for an RfC is consensus first, then implementation of said consensus. In the meantime, the status quo should be upheld. It is far, far more disruptive to revert back and forth than it is to keep the current changes in place. ''''']''''' 🌀 (]) 19:19, 11 April 2022 (UTC) |
|
|
|
| maxarchivesize = 100K |
|
|
|
|
|
| minthreadstoarchive = 2 |
|
== Template-protected edit request on 2 September 2022 == |
|
|
|
| minthreadsleft = 2 |
|
|
|
|
|
}} |
|
{{edit template-protected|Module:Storm categories/categories|answered=yes}} |
|
|
|
__FORCETOC__ |
|
Please add the icon for the "vstyphoon" category (around line 196): |
|
|
<syntaxhighlight lang="lua" line start="195"> |
|
|
name = "Very strong typhoon", |
|
|
sortkey = 60020, -- modified line (added comma) |
|
|
icon = "]" -- added line |
|
|
}, |
|
|
</syntaxhighlight> |
|
|
and the icon for the "vityphoon" category (around line 201): |
|
|
<syntaxhighlight lang="lua" line start="199"> |
|
|
color = "C464D9", |
|
|
name = "Violent typhoon", |
|
|
sortkey = 60030, -- modified line (added comma) |
|
|
icon = "]" -- added line |
|
|
}, |
|
|
</syntaxhighlight> <span style="background:#ffff55">''''']'''''</span> <small style="font-size:calc(1em - 2pt)">(])</small> 04:33, 2 September 2022 (UTC) |
|
|
|
|
|
:], could you please clarify: after the proposed changes are applied, will the overrides from ] need to be removed? —] (]) 07:27, 2 September 2022 (UTC) |
|
|
::@]: Well, they ''should'' be removed since an override would no longer be needed. It won't immediately break if there is a conflict. <span style="background:#ffff55">''''']'''''</span> <small style="font-size:calc(1em - 2pt)">(])</small> 07:31, 2 September 2022 (UTC) |
|
|
:{{done}}<!-- Template:ETp --> —] (]) 13:52, 2 September 2022 (UTC) |
|
|
::Thank you very much! <span style="background:#ffff55">''''']'''''</span> <small style="font-size:calc(1em - 2pt)">(])</small> 13:54, 2 September 2022 (UTC) |
|
|
|
|
|
== Template-protected edit request on 11 October 2022 == |
|
|
|
|
|
{{edit template-protected|Module:Storm categories/categories|answered=yes}} |
|
|
Could someone please revert the color changes I made on March 18, 2022, at ] per ]? All colors should be reverted to their pre-March 18 values per the SNOW support at that discussion. Please be careful to not remove any other additions to this module since then. ]<sup>]</sup> 17:25, 11 October 2022 (UTC) |
|
|
:{{done}}<!-- Template:ETp --> I think I found the right changes to make, but it is always a <em>lot</em> easier if you make the proposed changes in a sandbox and show it working on a testcases page. Please ping me if I made any unwanted changes. – ] (]) 18:48, 11 October 2022 (UTC) |
|
|
::Hi, @]! You accidentally reverted a few additions made earlier this year. ] on the sandbox page has the corrected module code. Previews are on ]. Please make the edit when you find the time. Thanks! {{smiley}} <span style="background:#ffff55">''''']'''''</span> <small style="font-size:calc(1em - 2pt)">(])</small> 03:23, 12 October 2022 (UTC) |
|
|
:::{{done}}. I think I've got it this time. If not, you know how to find me. – ] (]) 04:38, 12 October 2022 (UTC) |
|
|
|
|
|
== PTS colors == |
|
|
|
|
|
Just to raise awareness in a '''fourth''' location, I will link ] here, as well. – ]<span style="line-height: 1.3em;"><span style="font-size:large">𓅊</span></span>] 12:57, 28 November 2022 (UTC) |
|
|
|
|
|
== Template-protected edit request on 3 December 2022 == |
|
|
|
|
|
{{tper|Module:Storm categories/categories|answered=yes}} |
|
|
Please place the following line to alias the formerly-documented <code>vstrtyphoon</code> code (from ], later commented out) to <code>vstyphoon</code>, preferably above line 571. |
|
|
<syntaxhighlight lang="lua" line> |
|
|
cats = cats |
|
|
</syntaxhighlight> <span style="background:#ffff55">''''']'''''</span> <small style="font-size:calc(1em - 2pt)">(])</small> 13:43, 3 December 2022 (UTC) |
|
|
:{{edited2}}. ''''']''''' , ] ] <small>18:23, 3 December 2022 (UTC)</small> |
|
|
|
|
|
== Template-protected edit request on 6 February 2023 == |
|
|
|
|
|
{{tper|Module:Storm categories/categories|answered=yes}} |
|
|
Please change the name for "unknown" to "Unknown-strength storm" from "Unknown strength {{sic}} tropical cyclone". This module now includes much more than tropical cyclones, and the fallback should reflect the switch to a more general term. |
|
|
<syntaxhighlight lang="lua" line start="109"> |
|
|
-- ... |
|
|
unknown = { |
|
|
color = "c0c0c0", |
|
|
name = "Unknown-strength storm", |
|
|
-- ... |
|
|
</syntaxhighlight> |
|
|
Thank you! <span style="background:#ffff55">''''']'''''</span> <small style="font-size:calc(1em - 2pt)">(])</small> 00:26, 6 February 2023 (UTC) |
|
|
:{{edited2}}, and thank you very much''!'' ''''']''''' , ] ] <small>02:33, 6 February 2023 (UTC)</small> |
|
|
|
|
|
== Edit request 24 February 2023 == |
|
|
|
|
|
{{edit template-protected| Module:Storm categories/categories|answered=y}} |
|
|
'''Description of suggested change:''' |
|
|
|
|
|
Please substitute the preexisting colors in this template with the new colors agreed upon through RfC and further discussion, at ]. To simplify: |
|
|
|
|
|
* Entries with the color #80ccff should be changed to #0084D6 |
|
|
* Entries with the color #5ebaff should be changed to #6EC1EA |
|
|
* Entries with the color #00faf4 should be changed to #4DFFFF |
|
|
* Entries with the color #ccffff should be changed to #C0FFC0 |
|
|
* Entries with the color #ffffcc should be changed to #FFFFD9 |
|
|
* Entries with the color #ffe775 should be changed to #FFD98C |
|
|
|
|
|
* Entries with the color #ffc140 should be changed to #FF9E59 |
|
|
|
|
|
* Entries with the color #ff8f20 should be changed to #FF738A |
|
|
* Entries with the color #ff6060 should be changed to #8D75E6 |
|
|
|
|
|
That's a lot, I know, so thank you! ] <small>(] · ])</small> 01:15, 24 February 2023 (UTC) |
|
|
|
|
|
:Any chance you could make the changes to ]? — Martin <small>(] · ])</small> 19:42, 24 February 2023 (UTC) |
|
|
::{{re|MSGJ}} ] is the correct location for where changes should be made. I am adding them to the appropriate sandbox as we speak. Should be done in about 10 minutes. ]<sup>]</sup> 19:53, 24 February 2023 (UTC) |
|
|
:::{{re|MSGJ}} I believe I have changed everything correctly. ]<sup>]</sup> 20:09, 24 February 2023 (UTC) |
|
|
:{{done}}<!-- Template:ETp --> — Martin <small>(] · ])</small> 22:39, 24 February 2023 (UTC) |
|
|
::{{re|MSGJ}} Actually, it appears wxtrackercody was mistaken on some of the values given what was listed in the table (looks isolated to southern hemisphere TCs and north indian ocean TCs at the upper levels in their scales) so I need to go back and correct those. Sorry about that. ]<sup>]</sup> 23:03, 24 February 2023 (UTC) |
|
|
:::{{re|MSGJ}} All values should be corrected now. Again, sorry. I would have caught this had I been able to see a preview of the main module where it displays all the values, but alas that wasn't possible. ]<sup>]</sup> 23:13, 24 February 2023 (UTC) |
|
|
:::Also appears another issue is located at ]. The value 80ccff needs changed to 0084D6 (there's only one occurrence here) in order to stop it from overriding the input at the other module page. ]<sup>]</sup> 00:09, 25 February 2023 (UTC) |
|
|
::::{{ping|Hurricane Noah|wxtrackercody}} Another issue is that text does not show up well with the C5 color as background. For example, try reading "F5" on individual tornadoes' info-boxes. ] (]) 00:27, 25 February 2023 (UTC) |
|
|
:::::{{ping|CapeVerdeWave}} black text on the Cat 5 color background has a contrast ratio of 5.81:1, well above the threshold of 4.5:1 for WCAG 2.0 level AA as required by WP:ACCESS. ] <small>(] · ])</small> 00:33, 25 February 2023 (UTC) |
|
|
::::{{re|CapeVerdeWave|wxtrackercody}} Yes I notice that now. It must be an issue related to how WP displays it since it is AA compliant. We likely just need to use a slightly lighter value for templates while keeping the original for the maps since there isn't text there. {{colorbox|#a188fc}} would likely be favorable for black text on wiki while not being drastically different from the map color. I went ahead and added it to the sandbox since it's not a significant change from the original color we approved and we need to make sure everything can be read easily. ]<sup>]</sup> 00:34, 25 February 2023 (UTC) |
|
|
|
|
|
'''Re-filed edit request''' |
|
|
|
|
|
Please apply the changes currently on the sandbox (]), per the above. Thank you! <span style="background:#ffff55">''''']'''''</span> <small style="font-size:calc(1em - 2pt)">(])</small> 10:06, 25 February 2023 (UTC) |
|
|
|
|
|
:Please check ] and confirm all are now correct? There is still a "#80ccff" for "d" - is that right? — Martin <small>(] · ])</small> 10:28, 25 February 2023 (UTC) |
|
|
::@]: It seems @] forgot to account for overridden colors; the change has been made to ]. Please apply the changes to ] as well. Thank you! <span style="background:#ffff55">''''']'''''</span> <small style="font-size:calc(1em - 2pt)">(])</small> 10:34, 25 February 2023 (UTC) |
|
|
::All values should be correct now and work with the black text. ]<sup>]</sup> 15:55, 25 February 2023 (UTC) |
|
|
:::{{done}} — Martin <small>(] · ])</small> 16:16, 25 February 2023 (UTC) |
|
|
::::Thanks. ]<sup>]</sup> 16:17, 25 February 2023 (UTC) |
|
|
|
|
|
== Accidental short-circuit in ternary expressions at lines 51 and 73 == |
|
|
|
|
|
This module has a mistake at lines 51 and 73, in the instances of {{code|1=or (nullIfMissing and nil or )|lang=lua}}; these lines attempt to output <code>nil</code> if <code>nullIfMissing</code> is truthy and otherwise <code></code>, but because nil is falsy, the <code>or </code> will always trigger, and as such the expression simply short-circuits to <code>or </code>. {{''']'''|]|]}} 22:20, 12 April 2023 (UTC) |
|
|
|
|
|
:{{re|Lemondoge}} Good catch; didn't notice that. |
|
|
{{tper|answered=yes}} |
|
|
:Line 51 to: |
|
|
:<syntaxhighlight lang="lua" line start="51"> |
|
|
or (not nullIfMissing and error("No default name for basin-based category name.") or nil) |
|
|
</syntaxhighlight> |
|
|
:Line 73 to: |
|
|
:<syntaxhighlight lang="lua" line start="73"> |
|
|
) or (not nullIfMissing and cats.icon) or nil) |
|
|
</syntaxhighlight> |
|
|
:per the above. <span style="background:#ffff55">''''']'''''</span> <small style="font-size:calc(1em - 2pt)">(])</small> 22:48, 12 April 2023 (UTC) |
|
|
|
|
|
::{{edited2}}. ''''']''''' , ] ] <small>09:34, 13 April 2023 (UTC)</small> |
|
|
:::Thank you! <span style="background:#ffff55">''''']'''''</span> <small style="font-size:calc(1em - 2pt)">(])</small> 09:35, 13 April 2023 (UTC) |
|
|
::::''my pleasure!'' ''''']''''' <small>09:37, 13 April 2023 (UTC)</small> |
|
|
|
|
|
== Edit request 18 April 2023 == |
|
|
|
|
|
{{Edit template-protected|answered=}} |
|
|
|
|
|
Could you please replace ] with what's at ]? It includes many new scales for various events (most of which were pegged to the existing scheme and the drought ones were discussed ]) and icons for the Beaufort scale I produced. ]<sup>]</sup> 11:45, 18 April 2023 (UTC) |
|
