| Revision as of 10:18, 25 June 2014 editThis, that and the other (talk | contribs)Edit filter managers, Extended confirmed users, New page reviewers, Rollbackers, Template editors20,243 edits →Request to be made a contributor on the GitHub twinkle repository: comment← Previous edit |
Revision as of 14:50, 25 June 2014 edit undoEnterprisey (talk | contribs)Edit filter managers, Autopatrolled, Administrators34,924 edits →Request to be made a contributor on the GitHub twinkle repository: reNext edit → |
| Line 20: |
Line 20: |
|
:: Hmm. I don't think I've ever seen you contribute to Twinkle before, APerson? At least I can't find anything in the ] archives. To be honest I'd rather see some more complex pull requests from you first: I don't usually test changes before putting them live since currently I know I can rely on and trust all committers (TTTatO in particular), and I'd really like to keep it that way.<br>But then again I hardly make any meaningful contributions to Twinkle these days so my opinion doesn't really count. :)<br>] 18:45, 24 June 2014 (UTC) |
|
:: Hmm. I don't think I've ever seen you contribute to Twinkle before, APerson? At least I can't find anything in the ] archives. To be honest I'd rather see some more complex pull requests from you first: I don't usually test changes before putting them live since currently I know I can rely on and trust all committers (TTTatO in particular), and I'd really like to keep it that way.<br>But then again I hardly make any meaningful contributions to Twinkle these days so my opinion doesn't really count. :)<br>] 18:45, 24 June 2014 (UTC) |
|
::: APerson hasn't yet made a substantial contribution. I would say the same as Amalthea: "To be honest I'd rather see some more complex pull requests from you first". Hence, I wouldn't support this request right now. {{u|APerson}}, if you're keen, keep at it; there are a lot of open bugs and feature requests that could do with some work, both in the GitHub issue tracker and at ]. Try having a go at fixing some of those and submitting some pull requests. To be a contributor to the repository, you would want to be at the point of submitting pull requests that we can merge straight away, or with only minor stylistic fixes. — <span style="border:dashed #666;border-width:1px 0 0 1px">]</span> and <span style="border:dashed #666;border-width:0 1px 1px 0">]</span> 10:18, 25 June 2014 (UTC) |
|
::: APerson hasn't yet made a substantial contribution. I would say the same as Amalthea: "To be honest I'd rather see some more complex pull requests from you first". Hence, I wouldn't support this request right now. {{u|APerson}}, if you're keen, keep at it; there are a lot of open bugs and feature requests that could do with some work, both in the GitHub issue tracker and at ]. Try having a go at fixing some of those and submitting some pull requests. To be a contributor to the repository, you would want to be at the point of submitting pull requests that we can merge straight away, or with only minor stylistic fixes. — <span style="border:dashed #666;border-width:1px 0 0 1px">]</span> and <span style="border:dashed #666;border-width:0 1px 1px 0">]</span> 10:18, 25 June 2014 (UTC) |
|
|
::::Thank you both for your feedback! ] (]) 14:50, 25 June 2014 (UTC) |
Hi! I would like to be made a contributor on the GitHub repository for twinkle so I can tag new issues and edit more efficiently without having to go through the pull request system. I've already made one merged pull request. APerson (talk!) 01:45, 24 June 2014 (UTC)
