Misplaced Pages

Module talk:Storm categories: Difference between revisions

Article snapshot taken from Wikipedia with creative commons attribution-sharealike license. Give it a read and then ask your questions in the chat. We can research this topic together.
Browse history interactively← Previous editNext edit →Content deleted Content addedVisualWikitext
Revision as of 18:41, 9 May 2023 editPppery (talk | contribs)Interface administrators, Administrators100,470 edits →Template-protected edit request on 6 May 2023← Previous edit Revision as of 07:17, 15 May 2023 edit undoLowercase sigmabot III (talk | contribs)Bots, Template editors2,296,195 editsm Archiving 1 discussion(s) to Module talk:Storm categories/Archive 1) (botNext edit →
Line 13: Line 13:
}} }}
__FORCETOC__ __FORCETOC__

== Accidental short-circuit in ternary expressions at lines 51 and 73 ==

This module has a mistake at lines 51 and 73, in the instances of {{code|1=or (nullIfMissing and nil or )|lang=lua}}; these lines attempt to output <code>nil</code> if <code>nullIfMissing</code> is truthy and otherwise <code></code>, but because nil is falsy, the <code>or </code> will always trigger, and as such the expression simply short-circuits to <code>or </code>. {&#123;''']'''&#124;]&#124;]&#125;} 22:20, 12 April 2023 (UTC)

:{{re|Lemondoge}} Good catch; didn't notice that.
{{tper|answered=yes}}
:Line 51 to:
:<syntaxhighlight lang="lua" line start="51">
or (not nullIfMissing and error("No default name for basin-based category name.") or nil)
</syntaxhighlight>
:Line 73 to:
:<syntaxhighlight lang="lua" line start="73">
) or (not nullIfMissing and cats.icon) or nil)
</syntaxhighlight>
:per the above. <span style="background:#ffff55">''''']'''''</span>&nbsp;<small style="font-size:calc(1em - 2pt)">(])</small> 22:48, 12 April 2023 (UTC)

::{{edited2}}. ''''']'''''&thinsp;,&nbsp;]&nbsp;]&nbsp;<small>09:34, 13 April 2023 (UTC)</small>
:::Thank you! <span style="background:#ffff55">''''']'''''</span>&nbsp;<small style="font-size:calc(1em - 2pt)">(])</small> 09:35, 13 April 2023 (UTC)
::::''my pleasure!''&nbsp;''''']'''''&nbsp;&nbsp;<small>09:37, 13 April 2023 (UTC)</small>


== Edit request 18 April 2023 == == Edit request 18 April 2023 ==

Revision as of 07:17, 15 May 2023

This is the talk page for discussing improvements to the Storm categories module.
Archives: 1Auto-archiving period: 31 days 
Module:Storm categories is permanently protected from editing because it is a heavily used or highly visible module. Substantial changes should first be proposed and discussed here on this page. If the proposal is uncontroversial or has been discussed and is supported by consensus, editors may use {{edit template-protected}} to notify an administrator or template editor to make the requested edit.

WikiProject iconWeather: Tropical Template‑class
WikiProject iconThis module is within the scope of WikiProject Weather, which collaborates on weather and related subjects on Misplaced Pages. To participate, help improve this article or visit the project page for details. WeatherWikipedia:WikiProject WeatherTemplate:WikiProject WeatherWeather
TemplateThis module does not require a rating on Misplaced Pages's content assessment scale.
Taskforce icon
This module is supported by WikiProject Tropical cyclones.


Edit request 18 April 2023

This edit request to Module:Storm categories/categories has been answered. Set the |answered= or |ans= parameter to no to reactivate your request.

Could you please replace Module:Storm categories/categories with what's at Module:Storm categories/categories/sandbox? It includes many new scales for various events (most of which were pegged to the existing scheme and the drought ones were discussed here) and icons for the Beaufort scale I produced. The new scales are properly displayed at Module:Storm categories/sandbox. Noah 11:45, 18 April 2023 (UTC)

 Done * Pppery * it has begun... 18:50, 20 April 2023 (UTC)

Template-protected edit request on 23 April 2022

This edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request.

Please update the current template with the version currently in the sandbox (compare). Please be careful not to copy over the top and the demo function of the module, which imports sandbox modules; only the relevant parts changed under the first few lines.

Three significant changes were made to the template:

  • An isEqual function was introduced to check if two categories are equal (while also checking aliases),
  • nullIfMissing was renamed to nilIfMissing in all relevant functions.
  • _name was fixed to respect the nilIfMissing parameter, which it previously did not.

I've created the testcases page for future reference and for showing that the changes work (see run results). Please let me know if there's any additional changes that need to be made. Thanks! Chlod (say hi!) 09:13, 23 April 2023 (UTC)

 Completed. P.I. Ellsworth , ed.  15:38, 24 April 2023 (UTC)
Thank you! Chlod (say hi!) 01:50, 25 April 2023 (UTC)
my pleasure! Paine  03:51, 25 April 2023 (UTC)

Template-protected edit request on 6 May 2023

This edit request to Module:Storm categories/categories has been answered. Set the |answered= or |ans= parameter to no to reactivate your request.

Please replace the text on the Module:Storm categories/categories page with what's currently at Module:Storm categories/categories/sandbox. The change includes more new scales as well as the addition of dozens of status icon images. Please see Module:Storm categories/sandbox for the display of the colors and images at the sandbox page. Noah 21:41, 6 May 2023 (UTC)

 Done * Pppery * it has begun... 18:41, 9 May 2023 (UTC)
Categories: