Misplaced Pages

Revision as of 13:34, 4 January 2015

Template-protected edit request on 14 July 2014

This edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request.

In response to User_talk:The_Mol_Man#Template:Episode_list, a small change I made to the wikitext() function should fix it. It's found in this revision of the sand box (it's safe to just replace the module with the code on the /sandbox). I have no idea what was causing the issue in the first place. It appears to have been some issue with how Lua is creating the wikitext. moluɐɯ 20:04, 14 July 2014 (UTC)

A similar edit was made without knowledge of this request moluɐɯ 20:09, 14 July 2014 (UTC)

That was me. The reason is didn't work is because the parser does not generate <p>...</p> tags unless the text starts on a new line. That is what I added. Your hack was quite over the top. Just remember that anything in wikitext() is sent straight to the parser and should therefor behave exactly as wikitext. -- ] {{talk}} 20:14, 14 July 2014 (UTC)

My hack also included something that would have decreased the spacing between the headers, though he seems to not have a problem with that anymore judging by my talk page. Other than that, it was just your edit with some redundant <p> tags. moluɐɯ 20:21, 14 July 2014 (UTC)

Template-protected edit request on 5 December 2014

This edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request.

This module fails to place a space between the Title (which is rendered in quotes) and RTitle, in cases where the call includes both parameters. For example, the following strings are rendered at List of South Park episodes#Shorts, sketches, and other appearances (note the lack of a space after the closing quotation mark):

• "Magic: The Gathering"promotional bumper
• "Kenny's Dead"music video
• "The Aristocrats"sketch

While my Lua experience is modest, I suggest either of the following changes:

• title_string = title_string..'"'..args.Title..'"'
  

  ...to...

title_string = title_string..'"'..args.Title..'" '

, or change...

• title_string = title_string..args.RTitle
  

  ...to...

title_string = title_string..' '..args.RTitle

Thanks in advance! – voidxor  23:10, 5 December 2014 (UTC)

Above examples are crude. A better way is to only add a space when both args are present. -- ] {{talk}} 00:05, 6 December 2014 (UTC)

True, so how about we insert the following at line #141 instead?

if args.Title and args.RTitle then
    title_string = title_string..' '
end

– voidxor  05:59, 6 December 2014 (UTC)

Not done: please make your requested changes to the module's sandbox first; see WP:TESTCASES. Test your proposal in the sandbox and then reactivate this request when you've fully tested it. Thanks. — {{U|Technical 13}} 06:55, 17 December 2014 (UTC)

Implemented in sandbox. Can someone test? -- ] {{talk}} 10:29, 18 December 2014 (UTC)

I setup a test by having Template:Episode list/sandbox invoke Module:Episode list/sandbox. Examples are already setup at Template:Episode list/testcases, and the only changes appear in the reference tests. Everything appears to be working properly. The only question is, are we willing to have a space between the closing quotation mark of an episode title, and the citation for that title—in cases where the RTitle parameter is used for a title reference instead of a raw title? – voidxor  00:00, 19 December 2014 (UTC)

I had not considered that... But in those cases (as wel as the cases shown above), one can use RTitle for everything at once. The only downside being having to add the quotes yourself. In which case, so we still need the added spaces? -- ] {{talk}} 09:46, 20 December 2014 (UTC)

My opinion at this time is that adding a space (as you have done in the sandbox) is not a perfect solution, but it's better than the status quo. I'd go ahead and add it, unless somebody else chimes in with a better proposal. – voidxor  02:28, 21 December 2014 (UTC)

Note: Is there a way to check if args.RTitle starts with <ref</code? If so, we can have it not add the space in cases where that is true and reduce the number of spaces before refs. Maybe we can get some help from Jacmcbarn or Mr. S on this. :) — {{U|Technical 13}} 12:50, 4 January 2015 (UTC)